Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2843 Build repository community edition #56

Merged
merged 20 commits into from
Oct 8, 2024
Merged

OPSEXP-2843 Build repository community edition #56

merged 20 commits into from
Oct 8, 2024

Conversation

gionn
Copy link
Member

@gionn gionn commented Oct 3, 2024 •
edited
Loading

OPSEXP-2843

Testing in a new PR after #53 or into that

@gionn gionn self-assigned this Oct 3, 2024
@gionn gionn requested review from alxgomz and pmacius October 3, 2024 13:57
pmacius
pmacius previously approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gionn gionn force-pushed the OPSEXP-2843-repository-community branch from 5bb1dc7 to 4d9807f Compare October 4, 2024 09:11
@gionn gionn removed the request for review from alxgomz October 4, 2024 09:12
alxgomz
alxgomz requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good though dtas tests are failing

@gionn gionn force-pushed the OPSEXP-2843-repository-community branch 2 times, most recently from 05a9a04 to f6cb7e1 Compare October 7, 2024 12:28
@gionn gionn force-pushed the OPSEXP-2843-repository-community branch 4 times, most recently from a0b7cd1 to 4184330 Compare October 7, 2024 14:39
gionn added 2 commits October 7, 2024 16:40
@gionn
fixup sed preprocess
acc75d8 
use edition-specific overrides
@gionn
Revert "TO REVERT"
6745b8b 
This reverts commit e18986e.
@gionn gionn force-pushed the OPSEXP-2843-repository-community branch from 4184330 to 6745b8b Compare October 7, 2024 14:40
@gionn gionn force-pushed the OPSEXP-2843-repository-community branch from 0e85111 to 4f1ba93 Compare October 7, 2024 15:34
@gionn gionn requested review from pmacius and alxgomz October 8, 2024 07:16
alxgomz
alxgomz requested changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Can you please move to using an ENTRYPOINT script as we agreed to do as a standard on this repo?

README.md Outdated Show resolved Hide resolved
pmacius
pmacius previously approved these changes Oct 8, 2024
View reviewed changes
@gionn gionn requested a review from alxgomz October 8, 2024 08:05
@alxgomz alxgomz self-requested a review October 8, 2024 08:11
alxgomz
alxgomz requested changes Oct 8, 2024
View reviewed changes
repository/Dockerfile Show resolved Hide resolved
@gionn gionn force-pushed the OPSEXP-2843-repository-community branch from c901ad7 to 71353c7 Compare October 8, 2024 08:33
@gionn gionn requested a review from alxgomz October 8, 2024 09:03
@gionn gionn merged commit 018d004 into main Oct 8, 2024
9 checks passed
@gionn gionn deleted the OPSEXP-2843-repository-community branch October 8, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxgomz alxgomz alxgomz approved these changes

@pmacius pmacius pmacius left review comments

Assignees

@gionn gionn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gionn @alxgomz @pmacius